[webkit-reviews] review denied: [Bug 65288] Add checks to ensure allocation does not take place during initialization of GC-managed objects : [Attachment 102309] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 65288: Add checks to ensure allocation does not take place during
initialization of GC-managed objects
https://bugs.webkit.org/show_bug.cgi?id=65288

Attachment 102309: Patch
https://bugs.webkit.org/attachment.cgi?id=102309&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102309&action=review


Use an RAII object for the setInitializingObject(false/true) calls

> Source/JavaScriptCore/runtime/JSGlobalData.h:232
> +#if ENABLE(GC_VALIDATION)
> +	       m_initializingObject = value; 
> +#else
> +#endif

add UNUSED_PARAM(value) to the else block