[webkit-reviews] review requested: [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port : [Attachment 102258] Implementation for doneWithKeyEvent for WK2 GTK port - revision 5

[bugzilla-daemon at webkit.org]

Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com> has asked  for
review:
Bug 64790: [GTK][WK2] Handle doneWithKeyEvent in GTK port
https://bugs.webkit.org/show_bug.cgi?id=64790

Attachment 102258: Implementation for doneWithKeyEvent for WK2 GTK port -
revision 5
https://bugs.webkit.org/attachment.cgi?id=102258&action=review

------- Additional Comments from Ravi Phaneendra Kasibhatla
<ravi.kasibhatla at motorola.com>
Addressed the concerns & comments of carlos & martin.
As per explanation given by Carlos, since gtk_main_do_event is sync & gets
invoked only for event which is being passed gtk_main_do_event, reverting to
boolean flag. 
As per understanding with Martin & Carlos now keeping the WebKitWebViewPrivate
in .cpp only and exposing a new API to set the flag from PageClientImpl.
As per discussion with Carlos & Martin, NativeWebKeyboardEvent::nativeEvent now
returns a non-const GdkEvent. Removing the casting & event copy from
PageClientImpl.