[webkit-reviews] review denied: [Bug 65200] CSS Regions build bot should archive and upload output files : [Attachment 102233] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 65200: CSS Regions build bot should archive and upload output files
https://bugs.webkit.org/show_bug.cgi?id=65200

Attachment 102233: Patch
https://bugs.webkit.org/attachment.cgi?id=102233&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102233&action=review


This is looking really close!

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:247
> +			 "upload": "true", "slavenames": ["adobe-mac-slave1"]

You can use a literal true value here. No need for the string. That will make
the master.cfg logic simpler.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-131
> -

You should leave this extra line in place to match standard Python style.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:133
> +    masterdest =
WithProperties("archives/%(fullPlatform)s-%(architecture)s-%(configuration)s%(e
xtraFeatures)s/%(got_revision)s.zip", extraFeatures=lambda
build:UploadBuiltProduct.determineExtraFeatures(build))

I'm surprised the lambda is needed.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:741
> +	       "upload": builder.pop("upload", None) == "true"

False would probably be a better default, especially once you start using a
real True value instead of a string.