[webkit-reviews] review granted: [Bug 64739] [Qt] Make the WebContextMenuProxyQt handle the full interactions between the views and the WebPageProxy : [Attachment 101183] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 26 06:33:43 PDT 2011


Andreas Kling <kling at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 64739: [Qt] Make the WebContextMenuProxyQt handle the full interactions
between the views and the WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=64739

Attachment 101183: Patch
https://bugs.webkit.org/attachment.cgi?id=101183&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101183&action=review


> Source/WebKit2/UIProcess/qt/WebContextMenuProxyQt.cpp:105
> +	       connect(qtAction, SIGNAL(triggered(bool)), this,
SLOT(actionTriggered(bool)), Qt::DirectConnection);

The Qt::DirectConnection here can be omitted, since the object is on the same
thread.


More information about the webkit-reviews mailing list