[webkit-reviews] review granted: [Bug 65153] shrink the header on the flakiness dashboard : [Attachment 101946] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 26 06:33:22 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 65153: shrink the header on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=65153

Attachment 101946: Patch
https://bugs.webkit.org/attachment.cgi?id=101946&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101946&action=review


> Tools/ChangeLog:9
> +	   instead of below the header when they content they're showing

Typo: "they content"

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1332
> +    var showUnexpectedPassesLink = 
linkHTMLToToggleState('showUnexpectedPasses', 'tests that have not failed in
last ' + g_resultsByBuilder[builder].buildNumbers.length + ' runs');

Extra space after =


More information about the webkit-reviews mailing list