[webkit-reviews] review granted: [Bug 65086] Fix AtomicString vs. String usage in accessibility code : [Attachment 101835] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 65086: Fix AtomicString vs. String usage in accessibility code
https://bugs.webkit.org/show_bug.cgi?id=65086

Attachment 101835: Patch
https://bugs.webkit.org/attachment.cgi?id=101835&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101835&action=review


> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1237
> -	   String idName = idVector[i];
> +	   AtomicString idName(idVector[i]);
>	   Element* idElement = scope->getElementById(idName);

There’s no value to having a local variable here. It should just be
getElementById(idVector[i]).