[webkit-reviews] review granted: [Bug 65085] Fix AtomicString vs. String usage in JSC binding : [Attachment 101834] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 24 17:35:49 PDT 2011


Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 65085: Fix AtomicString vs. String usage in JSC binding
https://bugs.webkit.org/show_bug.cgi?id=65085

Attachment 101834: Patch
https://bugs.webkit.org/attachment.cgi?id=101834&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This change is great. Even better would be some way to catch such things at
compile time. I’m tempted to suggest we make conversion from String to
AtomicString an explicit function instead of an implicit constructor.


More information about the webkit-reviews mailing list