[webkit-reviews] review denied: [Bug 64851] Optimize AnimationController::updateAnimations : [Attachment 101557] newPatch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied zeng huiqing
<huiqing.zeng at intel.com>'s request for review:
Bug 64851: Optimize AnimationController::updateAnimations
https://bugs.webkit.org/show_bug.cgi?id=64851

Attachment 101557: newPatch
https://bugs.webkit.org/attachment.cgi?id=101557&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101557&action=review


> Source/WebCore/dom/NodeRenderingContext.cpp:287
> +    newRenderer->setAnimatableStyle(m_context.releaseStyle(), true); //
setAnimatableStyle() can depend on renderer() already being set.

We try to avoid boolean parameters because they are hard to read at the call
site, like this. Enums are preferred.