[webkit-reviews] review granted: [Bug 64691] Web Inspector: RuntimeAgent.evaluateOn should not require "return X; " syntax. : [Attachment 101594] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 64691: Web Inspector: RuntimeAgent.evaluateOn should not require "return
X;" syntax.
https://bugs.webkit.org/show_bug.cgi?id=64691

Attachment 101594: Patch
https://bugs.webkit.org/attachment.cgi?id=101594&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101594&action=review


> LayoutTests/ChangeLog:5
> +

Please provide the change description.

> Source/WebCore/inspector/InjectedScriptSource.js:264
> +	       var resolvedArg =
this._objectForId(this._parseObjectId(arguments[i]));

You should drop(?) arguments in case they are from other injected scripts.

> Source/WebCore/inspector/Inspector.json:264
> +		       { "name": "arguments", "type": "array", "items": {
"type": "objectId", "description": "Identifier of the argument" }, "optional":
true, "description": "Call arguments." }

Please describe what happens when the arguments are from different frames.