[webkit-reviews] review denied: [Bug 64732] Refactor automatically generated JS DOM bindings to replace operator new with static create methods : [Attachment 101408] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 64732: Refactor automatically generated JS DOM bindings to replace operator
new with static create methods
https://bugs.webkit.org/show_bug.cgi?id=64732

Attachment 101408: Patch
https://bugs.webkit.org/attachment.cgi?id=101408&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101408&action=review


Please fix the Qt and windows builds.

> Source/JavaScriptCore/runtime/JSByteArray.h:82
> +	   static JSByteArray* create(ExecState* exec, Structure* structure,
WTF::ByteArray* storage)

The WTF:: should not be necessary here.

> Source/WebCore/bindings/js/JSAudioConstructor.h:39
>      class JSAudioConstructor : public DOMConstructorWithDocument {
> -    public:
> +    private:
>	   JSAudioConstructor(JSC::ExecState*, JSC::Structure*,
JSDOMGlobalObject*);

In general, we like putting the private section below the public section. I
would understand if you are trying to minimize the change to the functional
aspect, but please clean this up afterwords.