[webkit-reviews] review granted: [Bug 64314] REGRESSION(r89004): Video pauses and never resumes playing if scrubbed during playback : [Attachment 101282] Patch 3

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 64314: REGRESSION(r89004): Video pauses and never resumes playing if
scrubbed during playback
https://bugs.webkit.org/show_bug.cgi?id=64314

Attachment 101282: Patch 3
https://bugs.webkit.org/attachment.cgi?id=101282&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101282&action=review


> Source/WebCore/html/shadow/SliderThumbElement.cpp:283
> +    // We don't call event->setDefaultHandled() here intentionally.
> +    // http://webkit.org/b/64314

A better way to phrase this would be "We intentionally do not call
event->setDefaultHandled() here. It would probably be of more use to explain
why we don't call it rather than pointing to a bug.