[webkit-reviews] review denied: [Bug 64541] [Qt] Consider the scale of the page view when scrolling QTouchWebView. : [Attachment 100829] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 64541: [Qt] Consider the scale of the page view when scrolling
QTouchWebView.
https://bugs.webkit.org/show_bug.cgi?id=64541

Attachment 100829: Patch
https://bugs.webkit.org/attachment.cgi?id=100829&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100829&action=review


> Source/WebKit2/UIProcess/API/qt/qtouchwebview.cpp:42
> +    pageView->moveBy(deltaX * pageView->scale(), deltaY *
pageView->scale());

I think TouchViewInterface::panGestureRequestScroll() should use
m_viewportView->mapFromItem() and send the coordinate in the right space to the
viewport.

QTouchWebViewPrivate::scroll(qreal deltaX, qreal deltaY) should be in viewport
coordinate.