[webkit-reviews] review granted: [Bug 63674] Get webkit to compile with USE(CFNETWORK) enabled on Mac : [Attachment 100898] Compile fixes

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 63674: Get webkit to compile with USE(CFNETWORK) enabled on Mac
https://bugs.webkit.org/show_bug.cgi?id=63674

Attachment 100898: Compile fixes
https://bugs.webkit.org/attachment.cgi?id=100898&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100898&action=review


r=me, but please consider the min<>/max<> changes.

> Source/WebCore/platform/network/cf/ResourceErrorCF.cpp:123
>  #if PLATFORM(WIN)
>      errorCopy.m_certificate = m_certificate;
> +#else
> +    UNUSED_PARAM(errorCopy);
>  #endif

Is this not used or available on Mac OS X?

> Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:75
> +    return static_cast<time_t>(min(max(minTimeAsDouble, time +
kCFAbsoluteTimeIntervalSince1970), maxTimeAsDouble));

You should probably switch to min<time_t>() and max<time_t>() here instead of
casting the final result.