[webkit-reviews] review granted: [Bug 63674] Get webkit to compile with USE(CFNETWORK) enabled on Mac : [Attachment 100704] LoaderRunLoop changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 15 08:35:01 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 63674: Get webkit to compile with USE(CFNETWORK) enabled on Mac
https://bugs.webkit.org/show_bug.cgi?id=63674

Attachment 100704: LoaderRunLoop changes
https://bugs.webkit.org/attachment.cgi?id=100704&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100704&action=review


r=me

> Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:67
> +	       // FIXME: http://webkit.org/b/55402 - loaderRunLoop() should use
synchronization instead of while loop

Nit: I like "<>" around URLs, but it's not necessary.


More information about the webkit-reviews mailing list