[webkit-reviews] review denied: [Bug 64584] Avoid rounded rect corner-drawing overhead if no corners are visible : [Attachment 100939] proposed patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ian Henderson
<ianh at apple.com>'s request for review:
Bug 64584: Avoid rounded rect corner-drawing overhead if no corners are visible
https://bugs.webkit.org/show_bug.cgi?id=64584

Attachment 100939: proposed patch
https://bugs.webkit.org/attachment.cgi?id=100939&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100939&action=review


Let's see one more version. I'd also like to see an interactive testcase
attached to the bug (maybe a roundrect inside a scrollable overflow region) so
that behavior can be checked manually.

> Source/WebCore/ChangeLog:8
> +	   No new tests, behavior is unaffected.

Well, behavior is affected, but not in a way that should affect visible
rendering.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1425
> +    // If one of the corners falls outside the clip region, pretend it has
no radius.

The comment should mention that this is done for performance reasons.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1450
> +	   outerBorder.setRadii(adjustedOuterRadii);

You could avoid setting this if you didn't change any corners. I think you
should also skip this entire block if rect is entirely inside the clip.