[webkit-reviews] review granted: [Bug 62935] [GTK] Fix GTK unit tests failures when WebKit is build outside repository directory. : [Attachment 100705] Fix GTK unit test failures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 14 06:28:42 PDT 2011


Gustavo Noronha (kov) <gns at gnome.org> has granted Lukasz Slachciak
<l.slachciak at samsung.com>'s request for review:
Bug 62935: [GTK] Fix GTK unit tests failures when WebKit is build outside
repository directory.
https://bugs.webkit.org/show_bug.cgi?id=62935

Attachment 100705: Fix GTK unit test failures
https://bugs.webkit.org/attachment.cgi?id=100705&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100705&action=review


> Source/WebKit/gtk/tests/test_utils.c:31
> +    if (repoPath) {
> +	   if (g_chdir(repoPath))
> +	    return -1;

I believe this return is still misindented; there is a tab here. I'll land it
manually and fix it before doing it.


More information about the webkit-reviews mailing list