[webkit-reviews] review denied: [Bug 64283] Web Inspector: Focusing on another node while editing CSS property does not update styles : [Attachment 100796] [PATCH] Removed unused method

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 64283: Web Inspector: Focusing on another node while editing CSS property
does not update styles
https://bugs.webkit.org/show_bug.cgi?id=64283

Attachment 100796: [PATCH] Removed unused method
https://bugs.webkit.org/attachment.cgi?id=100796&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100796&action=review


Lets see how stylesheet update affects standard update routines.

> LayoutTests/inspector/styles/commit-with-selection-change.html:9
> +    WebInspector.showPanel("elements");

selectNodeAndWaitForStyles does select elements panel.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1935
> +    //   "selector" - edit selector (|target|: section whose selector to
edit next).

We need constants for these.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1999
> +	   var newTarget = this._newEditorTarget(userInput, previousContent,
context, moveDirection);

var nextTarget = this._nextEditorTarget...

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:2000
> +	   this.editingEnded(context, !!newTarget);

this.editingEnded(context, newTarget) ?

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:2027
> +	   function editTargetCallback(newTarget)

Make this a top level function _startEditingTarget() ?

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:2038
> +		   var subtarget = newTarget.subtarget;

name, value?