[webkit-reviews] review granted: [Bug 64467] [V8] Avoid memory leaks with hidden references. : [Attachment 100700] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Vitaly Repeshko
<vitalyr at chromium.org>'s request for review:
Bug 64467: [V8] Avoid memory leaks with hidden references.
https://bugs.webkit.org/show_bug.cgi?id=64467

Attachment 100700: Patch
https://bugs.webkit.org/attachment.cgi?id=100700&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100700&action=review


Thanks.  Very nice.

> Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:58
> +    return v8::String::NewSymbol(prefixedName.data(),
static_cast<int>(prefixedName.size()));

Beautiful, except for the int cast!  (but I presume that's a problem with the
V8 API).