[webkit-reviews] review denied: [Bug 64474] Make GestureRecognizerChromium aware of Frame : [Attachment 100696] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 13 13:09:57 PDT 2011
Adam Barth <abarth at webkit.org> has denied Varun Jain <varunjain at chromium.org>'s
request for review:
Bug 64474: Make GestureRecognizerChromium aware of Frame
https://bugs.webkit.org/show_bug.cgi?id=64474
Attachment 100696: Patch
https://bugs.webkit.org/attachment.cgi?id=100696&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100696&action=review
> Source/WebCore/platform/PlatformGestureRecognizer.h:59
> - virtual bool processTouchEventForGesture(const PlatformTouchEvent&,
EventHandler*, bool handled) = 0;
> + virtual bool processTouchEventForGesture(const PlatformTouchEvent&,
Frame*, bool handled) = 0;
Code in WebCore/platform cannot be aware of anything in WebCore outside
WebCore/platform. That means both EventHandler and Frame are forbidden.
More information about the webkit-reviews
mailing list