[webkit-reviews] review denied: [Bug 61632] [GTK] Use alloca() if available for control messages in ConnectionUnix : [Attachment 95172] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 08:50:50 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 61632: [GTK] Use alloca() if available for control messages in
ConnectionUnix
https://bugs.webkit.org/show_bug.cgi?id=61632

Attachment 95172: Patch
https://bugs.webkit.org/attachment.cgi?id=95172&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
While I admit that this may have some performance benefit, I don't think we
should add it until we know what sort of performance benefit. Also I have
concerns about using alloca with large data structures.


More information about the webkit-reviews mailing list