[webkit-reviews] review denied: [Bug 15799] textPath element does not re-render when referenced path changes : [Attachment 100047] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 15799: textPath element does not re-render when referenced path changes
https://bugs.webkit.org/show_bug.cgi?id=15799

Attachment 100047: Patch
https://bugs.webkit.org/attachment.cgi?id=100047&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
current trunk behavior:

WildFox: for <rect id="foo"> - if I change the id dynamically, you'll not get a
mutation event at all ever, if the value was already specified in markup
WildFox: if id="foo" was omitted from the markup, I'd only get a mutation event
the first time "id" is touched
...
with Robs patch:

[17:37] WildFox: rbuis: ok, very easy to construct the testcase now, where it
fails
[17:37] WildFox: rbuis: imagine <defs> <path d="..." /> </defs> (note, the
<path> has no id)
[17:38] WildFox: rbuis: <text> <textPath xlink:href="#foo"
[17:38] WildFox: now with a <script> call path.setAttribute('id', 'foo');
[17:38] WildFox: NamedNodeMap::addAttribute ->
Node::dispatchSubtreeModifiedEvent, would fire the listener the first time
[17:38] WildFox: then SVGStyledElement::svgAttributeChanged ->
SVGElement::fireMutationEventIfNeeded, would fire the listener the second time
...

We nailed down the remaining problem, Rob will come up with a fix! :-)