[webkit-reviews] review denied: [Bug 52262] More keybindings for input[type=range] : [Attachment 99949] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 00:23:33 PDT 2011


Kent Tamura <tkent at chromium.org> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 52262: More keybindings for input[type=range]
https://bugs.webkit.org/show_bug.cgi?id=52262

Attachment 99949: Patch
https://bugs.webkit.org/attachment.cgi?id=99949&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99949&action=review

> Source/WebCore/html/RangeInputType.cpp:188
> +    bool isVertical = element()->renderer()->style()->appearance() ==
SliderVerticalPart;

element()->renderer() can be null.
MediaVolumeSliderPart is also vertical.


More information about the webkit-reviews mailing list