[webkit-reviews] review denied: [Bug 15799] textPath element does not re-render when referenced path changes : [Attachment 99882] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 15799: textPath element does not re-render when referenced path changes
https://bugs.webkit.org/show_bug.cgi?id=15799

Attachment 99882: Patch
https://bugs.webkit.org/attachment.cgi?id=99882&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99882&action=review

Setting r- because of the previous comments.

> Source/WebCore/svg/SVGElementRareData.cpp:57
> +    RefPtr<MutationEvent> mutationEvent =
MutationEvent::create(eventNames().DOMSubtreeModifiedEvent, true);
> +    parent->handleLocalEvents(mutationEvent.get());

Why can't you just use dispatchSubtreeModifiedEvent here?

> Source/WebCore/svg/SVGPathElement.cpp:250
> +	       rareSVGData()->fireEventIfNeeded(this);

fireMutationEventIfNeeded ?