[webkit-reviews] review granted: [Bug 63851] Crash when loading a document in an editable WebView that has a subframe with an unstyled body : [Attachment 99528] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adele Peterson <adele at apple.com>'s
request for review:
Bug 63851: Crash when loading a document in an editable WebView that has a
subframe with an unstyled body
https://bugs.webkit.org/show_bug.cgi?id=63851

Attachment 99528: patch
https://bugs.webkit.org/attachment.cgi?id=99528&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99528&action=review

> Source/WebCore/editing/Editor.cpp:2893
>      CSSStyleDeclaration* style = element->style();
>      ASSERT(style);
> +    if (!style)
> +	   return;

This change seems OK, but I’m not sure why it’s needed.

> Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:223
> +    if (([webView mainFrame] == webFrame) && [webView isEditable])

No need for the parentheses here.