[webkit-reviews] review requested: [Bug 61726] [CSS Exclusions] Parse wrap-shape property : [Attachment 99531] Patch - fixed variables naming

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 1 15:46:55 PDT 2011


Chiculita Alexandru <achicu at adobe.com> has asked  for review:
Bug 61726: [CSS Exclusions] Parse wrap-shape property
https://bugs.webkit.org/show_bug.cgi?id=61726

Attachment 99531: Patch - fixed variables naming
https://bugs.webkit.org/attachment.cgi?id=99531&action=review

------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
Renamed "a" to "argument" and "i" to "argumentNumber". 
Also changed if's to switches. It removes the need to write if
(!argumentNumber) instead of if (argumentNumber == 0).
Also there's is no way to get more arguments then we account for in the switch.
That's because it checks for the size of the arguments list. Also added an
assert to check that.


More information about the webkit-reviews mailing list