[webkit-reviews] review denied: [Bug 63709] Disabled or read-only input type=search still allows clicking [x] to clear contents : [Attachment 99463] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 1 05:48:51 PDT 2011


Kent Tamura <tkent at chromium.org> has denied Kentaro Hara <haraken at google.com>'s
request for review:
Bug 63709: Disabled or read-only input type=search still allows clicking [x] to
clear contents
https://bugs.webkit.org/show_bug.cgi?id=63709

Attachment 99463: Patch
https://bugs.webkit.org/attachment.cgi?id=99463&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99463&action=review

> LayoutTests/fast/forms/search-disabled-readonly-expected.txt:8
> +Test on the input form with disabled=false and readonly=false
> +Click the cancel button:
> +PASS input.value is ""
> +... and then input one character:
> +PASS input.value is "b"

This doesn't cover the original scenario of disabled-search-input.html.
The scenario was:
  1. layout with <input type=search disabled>
  2. Click the center of it
  3. Type a key
  4. Expect that the character is inserted.

But, you don't need to cover the scenario if you don't remove
disabled-search-input.html.


More information about the webkit-reviews mailing list