[webkit-reviews] review requested: [Bug 63801] [Chromium] HTML5 Canvas context.createPattern(image, repetition) can throw TYPE_MISMATCH_ERR exception. : [Attachment 99465] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 1 05:49:05 PDT 2011
Hwang <luxtella at company100.net> has asked for review:
Bug 63801: [Chromium] HTML5 Canvas context.createPattern(image, repetition) can
throw TYPE_MISMATCH_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=63801
Attachment 99465: patch
https://bugs.webkit.org/attachment.cgi?id=99465&action=review
------- Additional Comments from Hwang <luxtella at company100.net>
JavaScriptCore treats this by JSCanvasRenderingContext2DCustom.cpp but V8 does
not treats this.
>From HTML5 canvas spec:
http://dev.w3.org/html5/2dcontext/#dom-context-2d-createpattern
"If the first argument isn't an img, canvas, or video element, throws a
TYPE_MISMATCH_ERR exception."
This patch makes Chromium pass
canvas/philip/tests/2d.pattern.image.undefined.html
More information about the webkit-reviews
mailing list