[webkit-reviews] review requested: [Bug 50916] Add support for dir=auto : [Attachment 80700] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 17:14:03 PST 2011


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 50916: Add support for dir=auto
https://bugs.webkit.org/show_bug.cgi?id=50916

Attachment 80700: Patch.
https://bugs.webkit.org/attachment.cgi?id=80700&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
This patch adds support for dir="auto" by calling defaultWritingMode when we
encounter an element with dir="auto".
A flag was added to indicate that a node or one of its ancestors has this
attribute and value, so that we can detect DOM changes quickly and adjust the
directionality accordingly.
The flag is one bit in an existing flag, so it does not consume extra memory.

This patch will fail to build on Windows, I will fix that in a future version
of the patch.

This patch will fail the style check. I don't think we should fix these style
errors.
(one error for consistency with the rest of the file, and the second error is
wrong).


More information about the webkit-reviews mailing list