[webkit-reviews] review canceled: [Bug 53203] CSS 2.1 failure: bidi-breaking-002.htm test fails (PARAGRAPH SEPARATOR does not break line) : [Attachment 80678] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 17:09:39 PST 2011


Levi Weintraub <leviw at google.com> has canceled Levi Weintraub
<leviw at google.com>'s request for review:
Bug 53203: CSS 2.1 failure: bidi-breaking-002.htm test fails (PARAGRAPH
SEPARATOR does not break line)
https://bugs.webkit.org/show_bug.cgi?id=53203

Attachment 80678: Patch
https://bugs.webkit.org/attachment.cgi?id=80678&action=review

------- Additional Comments from Levi Weintraub <leviw at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80678&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1796
> +		       if (c == '\n' && preserveNewline || category(c) &
(Separator_Line | Separator_Paragraph)) {

This needs parenthesis. Also removing r? while I figure out how to make this
fast enough to be usable.


More information about the webkit-reviews mailing list