[webkit-reviews] review denied: [Bug 52974] [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl : [Attachment 80667] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s request
for review:
Bug 52974: [Qt] enum QWebPage::WebAction doesn't have value
QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Attachment 80667: patch
https://bugs.webkit.org/attachment.cgi?id=80667&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80667&action=review

> Source/WebKit/qt/ChangeLog:8
> +	   Add QWebPage::CopyImageUrlToClipborad into QWebPage::WebAction.

Typo, CopyImageUrlToClipboard.

> Source/WebKit/qt/Api/qwebpage.cpp:1684
> +    \value CopyImageUrlToClipboard Copy the highlighted image's url to the
clipboard.

url -> URL

> Tools/ChangeLog:8
> +	   Add CopyImageUrlToClipborad into QtTestbrowser.

Typo, CopyImageUrlToClipboard.

> Tools/QtTestBrowser/webview.cpp:247
> +	   QAction* newTabAction = menu->addAction("Copy Image Address",
webPage, SLOT(copyImageUrlToClipboard()));

The 'newTabAction' variable name doesn't make sense here.

> Tools/QtTestBrowser/webview.cpp:248
> +	   menu->insertAction(menu->actions().at(4), newTabAction);

What's up with the at(4) here? How is the QMenu action list populated?