[webkit-reviews] review denied: [Bug 52994] WebKit should support -webkit-tab-size. : [Attachment 80152] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 31 13:00:51 PST 2011
Dave Hyatt <hyatt at apple.com> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 52994: WebKit should support -webkit-tab-size.
https://bugs.webkit.org/show_bug.cgi?id=52994
Attachment 80152: Patch
https://bugs.webkit.org/attachment.cgi?id=80152&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You forgot to patch RenderStyle::diff to return a Layout hint if this property
changes. I'd like to see a test that dynamically changes the tab-size, since
this was overlooked.
More information about the webkit-reviews
mailing list