[webkit-reviews] review requested: [Bug 53389] [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful : [Attachment 80646] Patch proposal + unit tests

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 53389: [Gtk] atk_text_set_caret_offset returns True even when it is
unsuccessful
https://bugs.webkit.org/show_bug.cgi?id=53389

Attachment 80646: Patch proposal + unit tests
https://bugs.webkit.org/attachment.cgi?id=80646&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a patch to fix this issue.

Notice that I included the needed code to consider list item markers (so we
return FALSE in case you try to set the caret in the middle of them), as it's
part of the solution for this bug, even if bug 53388 is not fixed yet and hence
set_caret_offset will return FALSE always regardless of the offset being in the
item's marker or in the item's text :-)

Asking for review now...