[webkit-reviews] review granted: [Bug 53303] Web Inspector: allow remote debugging with front-end served from the cloud. : [Attachment 80454] [PATCH] A better patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 28 08:44:47 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 53303: Web Inspector: allow remote debugging with front-end served from the
cloud.
https://bugs.webkit.org/show_bug.cgi?id=53303

Attachment 80454: [PATCH] A better patch.
https://bugs.webkit.org/attachment.cgi?id=80454&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80454&action=review

> Source/WebCore/inspector/front-end/inspector.js:479
> +    else if ("page" in WebInspector.queryParamsObject)

Could you factor out if ("page" in WebInspector.queryParamsObject) in an outer
if block?


More information about the webkit-reviews mailing list