[webkit-reviews] review granted: [Bug 50660] Convert <progress> shadow DOM to a DOM-based shadow. : [Attachment 80424] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 28 08:43:25 PST 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 50660: Convert <progress> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50660

Attachment 80424: Patch
https://bugs.webkit.org/attachment.cgi?id=80424&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80424&action=review

Ok. You probably should've put this patch into a separate bug, since it doesn't
technically fix the bug yet -- and use this bug as a meta-bug :)

> Source/WebCore/html/HTMLProgressElement.cpp:40
> +class ProgressBarValueElement : public ShadowBlockElement {

Does it need to be ShadowBlockElement anymore? But I guess that's what the next
patch is about.


More information about the webkit-reviews mailing list