[webkit-reviews] review denied: [Bug 52296] [Qt]Add local storage settings to QtTestBrowser option menu : [Attachment 79846] Updated the patch according to suggested change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 02:18:59 PST 2011


Andreas Kling <kling at webkit.org> has denied suchi <suchi.kundu at nokia.com>'s
request for review:
Bug 52296: [Qt]Add local storage settings to QtTestBrowser option menu
https://bugs.webkit.org/show_bug.cgi?id=52296

Attachment 79846: Updated the patch according to suggested change
https://bugs.webkit.org/attachment.cgi?id=79846&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79846&action=review

> Tools/QtTestBrowser/launcherwindow.cpp:919
> +	   QDialog* dialog = new QDialog(this);

This whole section could be replaced with a call to QInputDialog::getInt(),
let's do that instead.

> Tools/QtTestBrowser/main.cpp:167
> +	   windowOptions.useLocalStorage = true;	

Unnecessary whitespace.

> Tools/QtTestBrowser/main.cpp:178
> +	   windowOptions.offlineStorageDefaultQuotaSize = maxSize;	  

Ditto.


More information about the webkit-reviews mailing list