[webkit-reviews] review granted: [Bug 53189] SVG animation doesn't support calcMode discrete for number and color values. : [Attachment 80236] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 53189: SVG animation doesn't support calcMode discrete for number and color
values.
https://bugs.webkit.org/show_bug.cgi?id=53189

Attachment 80236: Patch
https://bugs.webkit.org/attachment.cgi?id=80236&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80236&action=review

r=me.

> Source/WebCore/svg/SVGAnimateElement.cpp:103
> +    bool isInFirstHalfOfAnimation = percentage < 0.5;

0.5f?

> LayoutTests/svg/animations/script-tests/animate-color-calcMode-discrete.js:38

> +	   ["animation", 0.001,    "rect", sample1],

Formatting, you should lign up the "rect" lines.