[webkit-reviews] review denied: [Bug 50621] Implement text-combine rendering code : [Attachment 79848] New patch with Dave's input.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Takumi Takano <takano at apple.com>'s
request for review:
Bug 50621: Implement text-combine rendering code
https://bugs.webkit.org/show_bug.cgi?id=50621

Attachment 79848: New patch with Dave's input.
https://bugs.webkit.org/attachment.cgi?id=79848&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I don't get how your RenderCombinedText::widthFromCache method ever gets
called.  RenderText isn't going to invoke the right one since it's not virtual.
 You need to patch RenderText::widthFromCache to ask if you're combined and if
so call RenderCombinedText's widthFromCache method after casting it.  (And then
make sure RenderCombinedText doesn't turn around and call
RenderText::widthFromCache any longer.)