[webkit-reviews] review granted: [Bug 53200] Generalize the mechanism view-sources uses to remember the source for an HTMLToken : [Attachment 80251] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 26 16:22:38 PST 2011
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 53200: Generalize the mechanism view-sources uses to remember the source
for an HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=53200
Attachment 80251: Patch
https://bugs.webkit.org/attachment.cgi?id=80251&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80251&action=review
This seems sane. Thank you for keeping it small.
> Source/WebCore/ChangeLog:37
> + - This function should eventuall be folded into HTMLTokenizer.
eventuall
> Source/WebCore/html/parser/HTMLSourceTracker.cpp:44
> + token.end(input.current().numberOfCharactersConsumed());
You shoudl add a FIXME about moving this to the tokenizer.
> Source/WebCore/html/parser/HTMLSourceTracker.h:39
> + void start(const HTMLInputStream&, HTMLToken&);
You should make it clear that this can be called multipel times.
More information about the webkit-reviews
mailing list