[webkit-reviews] review denied: [Bug 53183] MathExtras.h missing additional "using std::<cmathfunction>" statements : [Attachment 80214] Patch adding additional "using std::<cmathfunction>"
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 26 12:57:27 PST 2011
Darin Adler <darin at apple.com> has denied Nick Landry <nlandry at rim.com>'s
request for review:
Bug 53183: MathExtras.h missing additional "using std::<cmathfunction>"
statements
https://bugs.webkit.org/show_bug.cgi?id=53183
Attachment 80214: Patch adding additional "using std::<cmathfunction>"
https://bugs.webkit.org/attachment.cgi?id=80214&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80214&action=review
review- because this is breaking the build on every platform!
>> Source/JavaScriptCore/wtf/MathExtras.h:215
>> +using std::acos;
>
> Use 'using namespace std;' instead of 'using std::acos;'. [build/using_std]
[4]
The stylebot should enforce that rule in .cpp files, but not in .h files.
More information about the webkit-reviews
mailing list