[webkit-reviews] review granted: [Bug 52366] ScriptExecutionContext needs additional checks when active dom objects are created/destroyed : [Attachment 80209] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 12:53:36 PST 2011


Alexey Proskuryakov <ap at webkit.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 52366: ScriptExecutionContext needs additional checks when active dom
objects are created/destroyed
https://bugs.webkit.org/show_bug.cgi?id=52366

Attachment 80209: Patch
https://bugs.webkit.org/attachment.cgi?id=80209&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Since it's a bool and not a counter, please
ASSERT(!m_iteratingActiveDOMObjects) before setting it to true.

It's a little unfortunate to incur a release mode cost for a debug-only
assertion.


More information about the webkit-reviews mailing list