[webkit-reviews] review requested: [Bug 52422] [chromium] More crash in FontFallbackList::determinePitch(const Font* font) : [Attachment 80174] A carpet-bomb approach 3

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 52422: [chromium] More crash in FontFallbackList::determinePitch(const
Font* font)
https://bugs.webkit.org/show_bug.cgi?id=52422

Attachment 80174: A carpet-bomb approach 3
https://bugs.webkit.org/attachment.cgi?id=80174&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,

Thank you for your review and comments.

(In reply to comment #10)
> (From update of attachment 80034 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=80034&action=review
> > Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:419
> > +	 OutputDebugString(logFont->lfFaceName);
> 
> Is this needed?

Oops, this API call is just for debugging and I should have removed it. I have
removed this call.

> > Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:587
> > +	 if (dc) {
> > +	   GetLastResortFallbackFontProcData procData(this, &description,
fallbackFontName);
> > +	   EnumFontFamilies(dc, 0, getLastResortFallbackFontProc,
reinterpret_cast<LPARAM>(&procData));
> > +	   ReleaseDC(0, dc);
> > +
> > +	   if (procData.m_fontData)
> > +	     return procData.m_fontData;
> > +	 }
> 
> Wrong indentation.

Ah, thank you for noticing it. I have fixed the indentation.

Regards,

Hironori Bono