[webkit-reviews] review granted: [Bug 53018] Web Inspector: Incorrect on-hover evaluation of a variable named 'profile' : [Attachment 80067] [PATCH] Proposed change.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 25 23:56:32 PST 2011
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 53018: Web Inspector: Incorrect on-hover evaluation of a variable named
'profile'
https://bugs.webkit.org/show_bug.cgi?id=53018
Attachment 80067: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=80067&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80067&action=review
I'd really appreciate if you wrote a test for this fix.
> Source/WebCore/inspector/front-end/ScriptsPanel.js:328
> var self = this;
Can you bind the function below to "this" object instead like we do with other
callbacks.
More information about the webkit-reviews
mailing list