[webkit-reviews] review requested: [Bug 52873] Chromium DRT should provide command-line option for specifying timeout to ease debugging : [Attachment 80169] Updated patch: --no-timeout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 25 22:07:53 PST 2011


Xianzhu Wang <wangxianzhu at google.com> has asked  for review:
Bug 52873: Chromium DRT should provide command-line option for specifying
timeout to ease debugging
https://bugs.webkit.org/show_bug.cgi?id=52873

Attachment 80169: Updated patch: --no-timeout
https://bugs.webkit.org/attachment.cgi?id=80169&action=review

------- Additional Comments from Xianzhu Wang <wangxianzhu at google.com>
I just investigated non-Chromium DRTs and found that they are different from
Chromium DRTs about timeout. Chromium DRTs will call 'exit()' on timeout, while
non-Chromium DRTs call notifyDone() which will cause exiting in the next
message loop. So for the latter timeout is not a big issue for debugging.


More information about the webkit-reviews mailing list