[webkit-reviews] review denied: [Bug 53160] HTMLInputElement::setValue() should schedule change event when the element is focused : [Attachment 80168] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 53160: HTMLInputElement::setValue() should schedule change event when the
element is focused
https://bugs.webkit.org/show_bug.cgi?id=53160

Attachment 80168: Patch
https://bugs.webkit.org/attachment.cgi?id=80168&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80168&action=review

> Source/WebCore/ChangeLog:6
> +	   Fire onchange() event for focused text field after its value is
programmatically changed and focus is lost
> +	   https://bugs.webkit.org/show_bug.cgi?id=53160

Please update the bug title here.

> Source/WebCore/html/HTMLInputElement.cpp:897
> +	 else if (isTextField())
> +	    
toRenderTextControl(renderer())->setChangedSinceLastChangeEvent(true);

I don't think it's correct to do this just for text fields.  We probably want
to fire change event for other types of input elements as well.