[webkit-reviews] review granted: [Bug 53100] WK2 leaks when a page is closed : [Attachment 80110] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 53100: WK2 leaks when a page is closed
https://bugs.webkit.org/show_bug.cgi?id=53100

Attachment 80110: Patch
https://bugs.webkit.org/attachment.cgi?id=80110&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80110&action=review

This patch failed to apply because of a merge conflict, so we are not getting
EWS results for it. You probably should merge and post a new patch so we can
see if it breaks the build or not.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1412
> +    [self _setRemoteAccessibilityWindow:nil];

We may want to do this in viewDidMoveToWindow as well, as Anders suggested,
even though we can’t do it only there.