[webkit-reviews] review canceled: [Bug 38982] [Chromium] WebKit API: Support icon loading for <input type=file> : [Attachment 79703] Patch 7

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has canceled  review:
Bug 38982: [Chromium] WebKit API: Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982

Attachment 79703: Patch 7
https://bugs.webkit.org/attachment.cgi?id=79703&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
Thank you for reviewing!!!

Landed with the following fixes: http://trac.webkit.org/changeset/76491


View in context: https://bugs.webkit.org/attachment.cgi?id=79703&action=review

>> Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.cpp:52
>> +	    RefPtr<WebCore::Image> image = WebCore::BitmapImage::create();
> 
> nit: I recommend a 'using namespace WebCore' up top, so you can ditch the
WebCore::

Done.

>> Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.h:47
>> +	~WebIconLoadingCompletionImpl();
> 
> nit: I think the destructor here can be private.

Done.