[webkit-reviews] review denied: [Bug 52609] Add navigator.registerProtocolHandler behind a flag. : [Attachment 79883] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied James Kozianski
<koz at chromium.org>'s request for review:
Bug 52609: Add navigator.registerProtocolHandler behind a flag.
https://bugs.webkit.org/show_bug.cgi?id=52609

Attachment 79883: Patch
https://bugs.webkit.org/attachment.cgi?id=79883&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79883&action=review

Seems fine. I noted a few nits below.

The biggest problem is that this patch doesn't seem to apply (see all of the
purple ews statuses).

> Source/WebCore/loader/EmptyClients.h:148
> +	   virtual void registerProtocolHandler(const String&, const String&,
const String&, const String&) { }

indented too far.

> Source/WebKit/chromium/public/WebViewClient.h:327
> +	 const WebString& baseUrl, const WebString& url, const WebString&
title);

Align with ( from previous line.