[webkit-reviews] review denied: [Bug 52955] Web Inspector: first step of splitting InspectorController : [Attachment 79841] [patch] initial version. Rebased.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 52955: Web Inspector: first step of splitting InspectorController
https://bugs.webkit.org/show_bug.cgi?id=52955

Attachment 79841: [patch] initial version. Rebased. 
https://bugs.webkit.org/attachment.cgi?id=79841&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79841&action=review

Please provide proper diff for InspectorAgent copy. Rest looks good.

> Source/WebCore/ChangeLog:5
> +	   Web Inspector: first step of splitting InspectorController.

I'd say it is 41st step :)

> Source/WebCore/ChangeLog:11
> +	   2) s/nspectorController/nspectorAgent/g everywhere in
WebCore/inspector but InspectorInstrumentation;

Why not inspector instrumentation? Too many changes?

> Source/WebCore/ChangeLog:12
> +	   3) create a fake InspectorController as a child of InspectorAgent
for the rest of WebCore and WebKit;

"as a child of" -> "derived from"

> Source/WebCore/ChangeLog:14
> +	   The second step is a migration a small set of functions described in
bug 52510 from InspectorAgent to InspectorController.

is a migration _of_ small

> Source/WebCore/WebCore.exp.in:1359
> +__ZN7WebCore14InspectorAgent4showEv

This part is unnecessary. In the end of the day, WebCore should not expose
InspectorAgent. But I see that it is a temporary measure.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:1268
> +		4F2D205412EAE7B3005C2874 /* InspectorAgent.h in Headers */ =
{isa = PBXBuildFile; fileRef = 4F2D205212EAE7B3005C2874 /* InspectorAgent.h */;
settings = {ATTRIBUTES = (Private, ); }; };

Same as for exports, ATTRIBUTES=Private should not be there after the
refactoring.

> Source/WebCore/inspector/InspectorAgent.cpp:1
> +/*

Please add

[diff]
	renames = copies

In the .git/config

so that we could see the changes in the file.