[webkit-reviews] review denied: [Bug 49618] Move CharacterNames.h into WTF directory : [Attachment 74219] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 49618: Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

Attachment 74219: Patch
https://bugs.webkit.org/attachment.cgi?id=74219&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74219&action=review

r- to use fewer using statements in CharacterNames.h.

> JavaScriptCore/wtf/unicode/CharacterNames.h:112
> +using WTF::Unicode::blackSquare;
> +using WTF::Unicode::bullet;
> +using WTF::Unicode::carriageReturn;
> +using WTF::Unicode::ethiopicPrefaceColon;
> +using WTF::Unicode::hebrewPunctuationGeresh;
> +using WTF::Unicode::hebrewPunctuationGershayim;
> +using WTF::Unicode::horizontalEllipsis;
> +using WTF::Unicode::hyphen;
> +using WTF::Unicode::hyphenMinus;
> +using WTF::Unicode::ideographicComma;
> +using WTF::Unicode::ideographicFullStop;
> +using WTF::Unicode::ideographicSpace;
> +using WTF::Unicode::leftDoubleQuotationMark;
> +using WTF::Unicode::leftSingleQuotationMark;
> +using WTF::Unicode::leftToRightEmbed;
> +using WTF::Unicode::leftToRightMark;
> +using WTF::Unicode::leftToRightOverride;
> +using WTF::Unicode::minusSign;
> +using WTF::Unicode::newlineCharacter;
> +using WTF::Unicode::noBreakSpace;
> +using WTF::Unicode::objectReplacementCharacter;
> +using WTF::Unicode::popDirectionalFormatting;
> +using WTF::Unicode::replacementCharacter;
> +using WTF::Unicode::rightDoubleQuotationMark;
> +using WTF::Unicode::rightSingleQuotationMark;
> +using WTF::Unicode::rightToLeftEmbed;
> +using WTF::Unicode::rightToLeftMark;
> +using WTF::Unicode::rightToLeftOverride;
> +using WTF::Unicode::softHyphen;
> +using WTF::Unicode::space;
> +using WTF::Unicode::whiteBullet;
> +using WTF::Unicode::yenSign;
> +using WTF::Unicode::zeroWidthJoiner;
> +using WTF::Unicode::zeroWidthNonJoiner;
> +using WTF::Unicode::zeroWidthSpace;

Can't you just use this instead?

using WTF::Unicode;