[webkit-reviews] review granted: [Bug 52201] Code cleaning in rendering/mathml/RenderMathMLFraction.cpp : [Attachment 79726] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 21 11:01:41 PST 2011


Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 52201: Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201

Attachment 79726: Patch
https://bugs.webkit.org/attachment.cgi?id=79726&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine, although I don’t think the "f" suffixes are needed. They do make
the constants into float constants, but since they are initializers for float I
know of no significant benefit to them being those. In fact, for integral
values I suggest omitting the decimal point as well.


More information about the webkit-reviews mailing list